chaoyli commented on a change in pull request #510: Be refactor optimize rowset URL: https://github.com/apache/incubator-doris/pull/510#discussion_r245956012
########## File path: be/src/olap/rowset/alpha_rowset.h ########## @@ -44,14 +44,25 @@ class AlphaRowset : public Rowset { virtual OLAPStatus remove(); - virtual RowsetMetaSharedPtr get_meta(); + virtual RowsetMetaSharedPtr get_rs_meta() const; virtual void set_version(Version version); + virtual int get_data_disk_size() const; + + virtual int get_index_disk_size() const; + + virtual bool empty() const; + + virtual bool zero_num_rows() const; + + virtual size_t get_num_rows() const; + bool create_hard_links(std::vector<std::string>* success_links); bool remove_old_files(std::vector<std::string>* removed_links); + Review comment: empty line ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org