EmmyMiao87 commented on a change in pull request #456: Add routine load
statement
URL: https://github.com/apache/incubator-doris/pull/456#discussion_r244926882
##########
File path:
fe/src/main/java/org/apache/doris/load/routineload/RoutineLoadManager.java
##########
@@ -132,8 +149,140 @@ public void addNumOfConcurrentTasksByBeId(long beId) {
}
}
- public void addRoutineLoadJob(RoutineLoadJob routineLoadJob) {
- idToRoutineLoadJob.put(routineLoadJob.getId(), routineLoadJob);
+ public void addRoutineLoadJob(CreateRoutineLoadStmt createRoutineLoadStmt)
+ throws AnalysisException, DdlException, LoadException {
+ // check load auth
Review comment:
Analysis is used to check `Semantics`， but auth is not belong to
`Semantics`. So maybe put auth check in here is better?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
