chaoyli commented on a change in pull request #493: Make tablet and tablet_meta can be compiled URL: https://github.com/apache/incubator-doris/pull/493#discussion_r244917876
########## File path: be/src/olap/rowset/rowset.h ########## @@ -34,18 +34,23 @@ using RowsetSharedPtr = std::shared_ptr<Rowset>; class Rowset { public: + static Rowset* create(); Review comment: I found I need a interface, so I add in the rowset_meta.h. But what the implementation is may be relied on the implementor who write this class. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org