kangpinghuang commented on a change in pull request #493: Make tablet and
tablet_meta can be compiled
URL: https://github.com/apache/incubator-doris/pull/493#discussion_r244908166
##########
File path: be/src/olap/tablet_manager.cpp
##########
@@ -684,7 +683,7 @@ TabletSharedPtr
TabletManager::find_best_tablet_to_compaction(CompactionType com
OLAPStatus TabletManager::load_tablet_from_header(DataDir* data_dir, TTabletId
tablet_id,
TSchemaHash schema_hash, const std::string& header) {
std::unique_ptr<TabletMeta> tablet_meta(new TabletMeta());
- bool parsed = tablet_meta->ParseFromString(header);
+ bool parsed = tablet_meta->deserialize(header);
Review comment:
I think header should be renamed.
header -> tablet_meta_pb?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
