kangpinghuang commented on a change in pull request #448: Move load tablets to StorageEngine URL: https://github.com/apache/incubator-doris/pull/448#discussion_r242814723
########## File path: be/src/olap/storage_engine.cpp ########## @@ -966,8 +915,8 @@ OLAPStatus StorageEngine::start_trash_sweep(double* usage) { const uint32_t snapshot_expire = config::snapshot_expire_time_sec; const uint32_t trash_expire = config::trash_file_expire_time_sec; const double guard_space = config::disk_capacity_insufficient_percentage / 100.0; - std::vector<RootPathInfo> root_paths_info; - res = get_all_root_path_info(&root_paths_info); + std::vector<DataDirInfo> data_dir_infos; + res = get_all_root_path_info(&data_dir_infos); Review comment: get_all_root_path_info should be renamed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscr...@doris.apache.org For additional commands, e-mail: dev-h...@doris.apache.org