imay commented on a change in pull request #433: Get rid of choosing one tablet
by compaction
URL: https://github.com/apache/incubator-doris/pull/433#discussion_r242138645
##########
File path: be/src/olap/utils.cpp
##########
@@ -1104,11 +1104,11 @@ OLAPStatus Mutex::lock() {
}
OLAPStatus Mutex::trylock() {
- if (0 != pthread_mutex_trylock(&_lock)) {
- VLOG(3) << "failed to got the mutex lock. err=" << strerror(errno);
+ int rv = pthread_mutex_trylock(&_lock);
+ if (rv != 0) {
+ VLOG(3) << "failed to got the mutex lock. error=" << strerror(rv);
Review comment:
use strerror_r to make it thread safe
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
