kangpinghuang commented on a change in pull request #437: Move tablet
management code from StorageEngine to TabletManager
URL: https://github.com/apache/incubator-doris/pull/437#discussion_r242034788
##########
File path: be/src/olap/storage_engine.h
##########
@@ -489,37 +449,18 @@ class StorageEngine {
bool is_used;
};
- typedef std::map<int64_t, TableInstances> tablet_map_t;
- typedef std::map<std::string, uint32_t> file_system_task_count_t;
-
- TabletSharedPtr _get_tablet_with_no_lock(TTabletId tablet_id, SchemaHash
schema_hash);
- // 遍历root所指定目录, 通过dirs返回此目录下所有有文件夹的名字, files返回所有文件的名字
- OLAPStatus _dir_walk(const std::string& root,
- std::set<std::string>* dirs,
- std::set<std::string>* files);
+ typedef std::map<std::string, uint32_t> file_system_task_count_t;
// 扫描目录, 加载表
OLAPStatus _load_store(OlapStore* store);
- OLAPStatus _create_new_tablet_header(const TCreateTabletReq& request,
- OlapStore* store,
- const bool
is_schema_change_tablet,
- const TabletSharedPtr ref_tablet,
- TabletMeta* header);
-
- OLAPStatus _check_existed_or_else_create_dir(const std::string& path);
-
TabletSharedPtr _find_best_tablet_to_compaction(CompactionType
compaction_type);
- bool _can_do_compaction(TabletSharedPtr tablet);
-
- void _cancel_unfinished_schema_change();
OLAPStatus _do_sweep(
const std::string& scan_root, const time_t& local_tm_now, const
uint32_t expire);
- void _build_tablet_info(TabletSharedPtr tablet, TTabletInfo* tablet_info);
- void _build_tablet_stat();
+
Review comment:
additional empty line?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
