The vote is cancelled until we address Stefan's concerns. Colm.
On Mon, Dec 17, 2018 at 8:13 AM Li, Jiajia <[email protected]> wrote: > Hi Stefan, > > Thanks for the serious review. > > >The release includes binary artifacts of has-dist [1] which includes many > third-party libraries, but the required license/notice files are missing in > those dist packages. > > It's because N&L are not included in assembly.xml, I've fixed in the pull > request[1] > > >The dist archives also include the jdk.tools-1.8.jar which I assume we > are not allowed to distribute. It's a system dependency from > hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it? > > I've checked Hadoop does not include jdk.tool in distribution, I've > excluded it in [1] > > >PS: Dist packages of kdc-dist and tool-dist were not generated because > their pom.xml use a Maven profile "-Pdist" which probably was not enabled > during release build, but has-dist pom.xml does not inlude such a profile > so artifacts were built and deployed. > > I've added the "dist" Maven profile in has-dist pom.xml in [1] > > Could you have a look at the pull request? > > [1] https://github.com/apache/directory-kerby/pull/43 > > Thanks, > Jiajia > > -----Original Message----- > From: Stefan Seelmann [mailto:[email protected]] > Sent: Sunday, December 16, 2018 5:08 AM > To: Apache Directory Developers List <[email protected]>; > [email protected] > Subject: Re: [VOTE] - Release Apache Kerby 2.0.0 > > I'm afraid I have to give a -1. > > The release includes binary artifacts of has-dist [1] which includes many > third-party libraries, but the required license/notice files are missing in > those dist packages. > > The dist archives also include the jdk.tools-1.8.jar which I assume we are > not allowed to distribute. It's a system dependency from > hadoop-common/hadoop-annotatations lib, not sure if Hadoop includes it? > > PS: Dist packages of kdc-dist and tool-dist were not generated because > their pom.xml use a Maven profile "-Pdist" which probably was not enabled > during release build, but has-dist pom.xml does not inlude such a profile > so artifacts were built and deployed. > > [1] > > https://repository.apache.org/content/repositories/orgapachedirectory-1179/org/apache/kerby/has-dist/2.0.0/ > > > > On 12/11/18 12:49 PM, Colm O hEigeartaigh wrote: > > This is a vote to release Apache Kerby 2.0.0. > > > > Artifacts: > > > > https://repository.apache.org/content/repositories/orgapachedirectory- > > 1179/ > > > > Issues fixed: > > > > https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310 > > 910&version=12342433 > > > > Git tag: > > > > https://github.com/apache/directory-kerby/tree/kerby-all-2.0.0 > > > > +1 from me. > > > > Colm. > > > > > > -- Colm O hEigeartaigh Talend Community Coder http://coders.talend.com
