ZENOTME commented on code in PR #151:
URL: https://github.com/apache/datasketches-rust/pull/151#discussion_r3615913118
##########
datasketches/src/theta/intersection.rs:
##########
@@ -61,7 +63,12 @@ impl ThetaIntersection {
/// The intersection can be viewed as starting from the "universe" set,
/// and every update can reduce the current set to leave the overlapping
/// subset only.
- pub fn update<S: ThetaSketchView>(&mut self, sketch: &S) -> Result<(),
Error> {
+ #[allow(private_bounds)]
+ pub fn update<V>(&mut self, sketch: ThetaSketchView<V>) -> Result<(),
Error>
+ where
+ V: RawThetaSketchView<ThetaEntry>,
+ {
Review Comment:
To avoid trait here, we can use enum to dispatch.🤔
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
