tisonkun commented on code in PR #129: URL: https://github.com/apache/datasketches-rust/pull/129#discussion_r3258428399
########## RELEASE.md: ########## @@ -155,15 +155,9 @@ After successful vote, send [VOTE-RESULT] email summarizing the outcome and proc cd ~/apache/dist/dev/datasketches/scripts ./moveDevToRelease.sh rust 0.3.0-rc.1 0.3.0 -# Update Cargo.toml to final release version (this is the only version commit!) -cd /path/to/datasketches-rust -git checkout main -sed -i '' 's/version = ".*"/version = "0.3.0"/' datasketches/Cargo.toml -git add datasketches/Cargo.toml -git commit -m "chore: release 0.3.0" -git push origin main - # Create final release tag +cd /path/to/datasketches-rust +git checkout 0.3.0-rc.1 Review Comment: We should update the version in Cargo.toml beforehand. The RC tag to vote on is the final snapshot. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
