Copilot commented on code in PR #126:
URL: https://github.com/apache/datasketches-rust/pull/126#discussion_r3230753822
##########
.github/workflows/ci.yml:
##########
@@ -52,6 +52,8 @@ jobs:
- uses: taiki-e/install-action@v2
with:
tool: typos-cli,taplo-cli,hawkeye
+ - name: Check lockfile
+ run: cargo update -w --locked --verbose
Review Comment:
`cargo update -w --locked` is likely the wrong command for a lockfile
consistency check: `cargo update` tries to change `Cargo.lock` to newer
dependency versions, and with `--locked` it will error as soon as any
dependency update is available on crates.io (making CI fail
nondeterministically over time). If the intent is only to verify that the
committed lockfile matches the manifests, use a command that validates without
attempting to update (e.g. `cargo generate-lockfile --locked`, or `cargo
metadata --locked`, or a build/check step with `--locked`).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
