Copilot commented on code in PR #120: URL: https://github.com/apache/datasketches-rust/pull/120#discussion_r3212656238
########## datasketches/Cargo.toml: ########## @@ -34,6 +34,18 @@ keywords = ["sketch", "hyperloglog", "probabilistic"] all-features = true rustdoc-args = ["--cfg", "docsrs"] +[features] +default = [] + +# Each sketch has its own feature, so that users can opt in to only the sketches they need. +bloom = [] +countmin = [] +cpc = [] Review Comment: `default = []` means none of the sketch modules are enabled by default, so `datasketches::theta`/`hll`/etc disappear from the public API unless users opt-in via features. This is a breaking change and also doesn’t match the linked issue’s stated goal that all sketches be on by default. Consider setting `default` to include all sketch features (or define an `all` feature and make it the default). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
