tisonkun commented on PR #116:
URL:
https://github.com/apache/datasketches-rust/pull/116#issuecomment-4389422401
@notfilippo I noticed that the only pub constructor of `Coupon` is
`Coupon::from_hash`
Then could you show me a real-world use case how making `Coupon` pub
different from:
```rust
let mut sketch = HllSketch::new(10, HllType::Hll8);
sketch.update_with_coupon(Coupon::from_hash("apple"));
// the same as sketch.update("apple");
```
> I don’t get the different hash variants for compatibility? All the hash
values must be an exact bit match across all languages or the sketches are not
compatible.
Yes. All hashed values are exact the same. The issue here is how we hash
values.
For example, in Java, there is no `uint_8` and `uint_16`, so it does not
need to consider how to hash `uint_8` (`u8` in rust) when users insert it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
