proost commented on PR #111: URL: https://github.com/apache/datasketches-rust/pull/111#issuecomment-4261488018
A few thoughts: 1. Go has standard hash interfaces, but they have not been convenient for ds-go in practice. Instead of relying on a hash interface, we have generally used common utility functions where needed. 2. In ds-go, as in ds-cpp and ds-java, the hash handling seems to differ from sketch to sketch. Because of that, I had not assumed there was a single common hashing model shared across all sketches. 3. Given that, I am not yet convinced that introducing a project-wide common hash interface would provide enough benefit over using shared utility functions where appropriate. 4. A project-wide hash interface would also create a broader compatibility obligation. If a new language implementation or a new sketch is introduced later, we would need to decide whether that interface still fits all cases and whether its semantics can remain forward-compatible across the project. Most case, I think, can be covered but I'm not sure. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
