proost opened a new pull request, #129: URL: https://github.com/apache/datasketches-go/pull/129
Situation: We use tuple sketch a lot. One of teams use tuple sektch extremely. One application has many tuple sketches, that each one has lots of summaries. So It makes a more than billion live objects in heap. So every GC period, especially Marking phase, go runtime uses too many CPU usages as well as it makes longer stop the world. So I propose supporting value-type receiver summary using "UpdateFunc". Normally, it is not that burden to allocate millions ~ less than billions live objects in heap. So current interface is ok. Also current interface is easy to use and easy to understand. Here is benchmark result: ``` goos: darwin goarch: arm64 pkg: github.com/apache/datasketches-go/tuple cpu: Apple M4 Pro BenchmarkUpdateSketch_PointerSummary BenchmarkUpdateSketch_PointerSummary-12 3956 301095 ns/op 318668 B/op 8917 allocs/op PASS goos: darwin goarch: arm64 pkg: github.com/apache/datasketches-go/tuple cpu: Apple M4 Pro BenchmarkUpdateSketch_ValueSummary BenchmarkUpdateSketch_ValueSummary-12 5446 213742 ns/op 280724 B/op 8 allocs/op PASS ``` Benchmark code is included in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
