nikunjbhartia commented on issue #144: URL: https://github.com/apache/datasketches-bigquery/issues/144#issuecomment-2715730680
I agree, having default params and function overloading would have made lives much easier :) Regaring the other comment, As an end user, I wouldn't know if I should use theta_sketch_agg_union() or theta_sketch_agg_union_lgk_seed() unless I have information about how the sketch was initialized. I would imagine that sketch creation and sketch extraction would be different flows and teams. But now I think just having the lg_k version of agg wouldn't help and we might also need lg_k version of union and I now understand when you say `combinatorial explosion` :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
