AlexanderSaydakov commented on code in PR #21:
URL: https://github.com/apache/datasketches-spark/pull/21#discussion_r1972571777
##########
src/main/scala/org/apache/spark/sql/datasketches/theta/aggregate/ThetaSketchAggUnion.scala:
##########
@@ -48,65 +54,81 @@ import org.apache.spark.sql.types.{AbstractDataType,
DataType, IntegerType}
)
// scalastyle:on line.size.limit
case class ThetaSketchAggUnion(
- left: Expression,
- right: Expression,
+ inputExpr: Expression,
+ lgKExpr: Expression,
+ seedExpr: Expression,
mutableAggBufferOffset: Int = 0,
inputAggBufferOffset: Int = 0)
extends TypedImperativeAggregate[ThetaSketchWrapper]
- with BinaryLike[Expression]
+ with TernaryLike[Expression]
Review Comment:
there is a set of overrides for this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
