+1 (binding) License, Notice look ok clean build all tests pass Tested on Mac Sonoma 14.5 I got a lot of “usr/local/opt/ruby/lib’ not found” warnings. But all the tests seem to run fine. Ironically, that is not where my ruby is loaded. But this seems harmless.
On Tue, Jul 30, 2024 at 10:05 AM Jon Malkin <jon.mal...@gmail.com> wrote: > +1 (binding) > > Verified signature/checksum > License/notice look good > clean build > all tests pass > > Tested on linux with gcc 13 > > > On Mon, Jul 29, 2024 at 2:15 PM Alexander Saydakov > <sayda...@yahooinc.com.invalid> wrote: > >> Hello Apache DataSketches PMC and Community, >> >> >> This is a call for vote to release Apache DataSketches-cpp candidate >> version 5.1.0-rc1 >> >> >> Changes since datasketches-cpp 5.0.2 release (12 January 2024): >> - implemented tdigest >> - added get_serialized_size_bytes() and >> get_max_serialized_size_bytes() to compact Theta sketch >> - fixed compressed Theta sketch stream serialization >> - added Tuple sketch filter() method >> >> Source repository: >> >> - https://github.com/apache/datasketches-cpp >> >> >> Git Tag for this release: >> >> - https://github.com/apache/datasketches-cpp/releases/tag/5.1.0-rc1 on >> branch 5.1.x >> >> >> Git HashId for this release is: da8c41f6c5fd04149b54b76d66cb22a5d24d560b >> >> >> The Release Candidate Zip Repository: >> >> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.1.0-rc1/ >> >> >> The public signing key can be found in the KEYS file: >> >> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >> >> >> >> The artifacts have been signed with key: >> >> 68486114A8E8B4E0 2019-08-20 Alexander Saydakov (CODE SIGNING KEY) < >> al...@apache.org> >> >> >> Build & Test Guide (C++): >> >> - https://github.com/apache/datasketches-cpp/blob/5.1.0-rc1/README.md >> >> >> The vote will be performed as follows: >> >> - This letter will be published on dev@ and remain open for at least >> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) >> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >> community can vote. >> >> >> Please vote accordingly: >> >> >> [ ] +1 approve >> >> [ ] +0 no opinion >> >> [ ] -1 disapprove with the reason >> >> >> Thank you, >> >> Alexander Saydakov >> >> al...@apache.org >> >>
