+1 (binding) - cmake -S . -B build/Release -DCMAKE_BUILD_TYPE=Release //successful - cmake --build build/Release -t all test //successful - LICENSE and NOTICE ok
On Tue, Dec 19, 2023 at 2:36 PM Alexander Saydakov <sayda...@yahooinc.com.invalid> wrote: > +1 > > - reviewed small patch applied to the previous release 5.0.0 > - checked GPG signature and SHA512 > - cmake, make, make test - successful > > > On Tue, Dec 19, 2023 at 9:04 AM Charlie Dickens > <charlie.dick...@yahooinc.com.invalid> wrote: > >> +1 >> >> Downloaded and installed on mac os ventura 13.6.1 >> ran unit tests >> checked license and notice >> verified shasum and correct keys >> >> On Tue, 19 Dec 2023 at 08:55, Jon Malkin <jmal...@apache.org> wrote: >> >>> Hello Apache DataSketches PMC and Community, >>> >>> >>> This is a call for vote to release Apache DataSketches-cpp candidate >>> version 5.0.1-rc1 >>> >>> >>> This is a patch release that addresses two bugs found while working on >>> the first independent python release. >>> >>> >>> The changes are: >>> >>> - Fix two bugs in KLL where std::move() tried writing in the source >>> range >>> >>> - Fix EBPPS to_string() to work with a wider variety of input types >>> >>> >>> Source repository: >>> >>> - https://github.com/apache/datasketches-cpp >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp__;!!Op6eflyXZCqGR5I!B6H2_8eZHpuoztJ5gU4RLy5cm5alDjiuFl7D0opq6XVCrVC4fPN18dLQVPn2TyLp5UvE_gAem7NVDOJjQbgjpack0Q$> >>> >>> >>> Git Tag for this release: >>> >>> - https://github.com/apache/datasketches-cpp/releases/tag/5.0.1-rc1 >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/releases/tag/5.0.1-rc1__;!!Op6eflyXZCqGR5I!B6H2_8eZHpuoztJ5gU4RLy5cm5alDjiuFl7D0opq6XVCrVC4fPN18dLQVPn2TyLp5UvE_gAem7NVDOJjQbgTDbEIcA$> >>> on >>> branch 5.0.x >>> >>> >>> Git HashId for this release is: 7934d4c680c0417154f91005e4eb6775a48292da >>> >>> >>> The Release Candidate Zip Repository: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.1-rc1/ >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/cpp/5.0.1-rc1/__;!!Op6eflyXZCqGR5I!B6H2_8eZHpuoztJ5gU4RLy5cm5alDjiuFl7D0opq6XVCrVC4fPN18dLQVPn2TyLp5UvE_gAem7NVDOJjQbjB2yrNkw$> >>> >>> >>> The public signing key can be found in the KEYS file: >>> >>> - https://dist.apache.org/repos/dist/dev/datasketches/KEYS >>> <https://urldefense.com/v3/__https://dist.apache.org/repos/dist/dev/datasketches/KEYS__;!!Op6eflyXZCqGR5I!Fz5YQTb3Gb2to0dakSYd2uO02qCG6L7a0ELZzKrl0jmHWD9g17TQnzUZULBSqlh0o7SYwemE3RbSgSuNGw$> >>> >>> >>> >>> The artifacts have been signed with key: >>> >>> 41A98F6038F334CC Jon Malkin (Apache code signing) < >>> jmal...@users.noreply.github.com> >>> >>> Build & Test Guide (C++): >>> >>> - >>> https://github.com/apache/datasketches-cpp/blob/5.0.1-rc1/README.md >>> <https://urldefense.com/v3/__https://github.com/apache/datasketches-cpp/blob/5.0.1-rc1/README.md__;!!Op6eflyXZCqGR5I!B6H2_8eZHpuoztJ5gU4RLy5cm5alDjiuFl7D0opq6XVCrVC4fPN18dLQVPn2TyLp5UvE_gAem7NVDOJjQbhax4OdxA$> >>> >>> >>> The vote will be performed as follows: >>> >>> - This letter will be published on dev@ and remain open for at least >>> 72 hours (excluding weekends and holidays), AND until at least 3 (+1) >>> PMC votes or a majority of (+1) PMC votes are acquired. Anyone in the >>> community can vote. >>> >>> >>> Please vote accordingly: >>> >>> >>> [ ] +1 approve >>> >>> [ ] +0 no opinion >>> >>> [ ] -1 disapprove with the reason >>> >>> >>> Thank you, >>> >>> Jon Malkin >>> >>> jmal...@apache.org >>> >>>
