blackmwk commented on PR #1: URL: https://github.com/apache/datafusion-iceberg/pull/1#issuecomment-5660949318
> Done, the folder structure is the following one: > > * `src/`: the main crate with the DataFusion integration, what previously was `crates/integrations/datafusion/` > * `sqllogictest/`: crate with the sqllogictests, what previously was `crates/sqllogictest/` > * `playground/`: crate with the iceberg-playground tool, what previously was `crates/integrations/playground/` > > This means that even if there's a workspace with attached crates, there's still one main central crate that is DataFusion integration. It's not exactly the same folder structure we had before, but IMO this is a good solution. Happy to hear other opinions if any. Thanks @gabotechs for porting the changes. I would sugges to keep the origin crates dir, and put each crates under them for serveral reasons: 1. A repo will not only contain code, but also build scripts, license file, doc file etc. If we put the main crate in the root dir, it will make things a little difficult to maintain and read. 2. Sometimes we may need discover all crates dynamically in scripts, and putting all crates under a `crates` dir makes this easier to do. It's not a blocker, but it's a convention followed by most multi crate projects. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
