kevinjqliu commented on code in PR #2:
URL: https://github.com/apache/datafusion-iceberg/pull/2#discussion_r3972611592
##########
Cargo.toml:
##########
@@ -16,34 +16,33 @@
# under the License.
[package]
-edition = { workspace = true }
-homepage = { workspace = true }
-name = "iceberg-datafusion"
+edition = "2024"
+homepage = "https://rust.iceberg.apache.org/";
Review Comment:
ok for now, we may want to move this later
##########
src/physical_plan/repartition.rs:
##########
@@ -76,7 +76,7 @@ use iceberg::spec::{TableMetadata, TableMetadataRef,
Transform};
///
/// ```ignore
/// use std::num::NonZeroUsize;
-/// use iceberg_datafusion::physical_plan::project_with_partition;
+/// use datafusion_iceberg::physical_plan::project_with_partition;
Review Comment:
😄
##########
Cargo.toml:
##########
@@ -16,34 +16,33 @@
# under the License.
[package]
-edition = { workspace = true }
-homepage = { workspace = true }
-name = "iceberg-datafusion"
+edition = "2024"
+homepage = "https://rust.iceberg.apache.org/";
+name = "datafusion-iceberg"
publish = true
-rust-version = { workspace = true }
-version = { workspace = true }
+version = "0.10.1"
categories = ["database"]
description = "Apache Iceberg DataFusion Integration"
keywords = ["iceberg", "integrations", "datafusion"]
-license = { workspace = true }
-repository = { workspace = true }
+license = "Apache-2.0"
+repository = "https://github.com/datafusion-contrib/datafusion-iceberg";
[dependencies]
-anyhow = { workspace = true }
-async-trait = { workspace = true }
-dashmap = { workspace = true }
-datafusion = { workspace = true }
-futures = { workspace = true }
-iceberg = { workspace = true }
-parquet = { workspace = true }
-tokio = { workspace = true }
-uuid = { workspace = true }
+anyhow = "1.0.72"
+async-trait = "0.1.89"
+dashmap = "6"
+datafusion = "55.0.0"
+futures = "0.3"
+iceberg = { git = "https://github.com/apache/iceberg-rust";, rev =
"665c64e48e8d33797ecb1a421f327edd9b024879" }
Review Comment:
do we want to pin to hash or use the latest release?
https://crates.io/crates/iceberg/versions
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
