Thank you for preparing this! I did briefly want to call out [1], as it fixes a bug in the (brand new and awesome!) field metadata/extension type support that Tim has been championing whereby metadata is obliterated in some situations involving literals (e.g., [2]). This renders the field metadata/extension type support unusable/unreliable for the general case (possibly for any query that involves a metadata-enabled scalar function call on a literal) at the moment. Given that there were some breaking changes required to make this support possible, I wonder if it is worth considering that PR for the release?
Cheers, -dewey [1] https://github.com/apache/datafusion/pull/16170 [2] https://github.com/geoarrow/geoarrow-rs/pull/1106 On Fri, Jun 6, 2025 at 9:37 AM Andy Grove <andygrov...@gmail.com> wrote: > I ran into an issue when upgrading from rc1 to rc2, and I added the details > in > https://github.com/apache/datafusion/issues/15771#issuecomment-2949450136 > but to summarize here, a windowed aggregate test fails with "attempt to > subtract with overflow". The relevant part of the stack trace is: > > 2025-06-06T13:57:54.1903145Z at > > datafusion_expr::window_state::WindowAggState::update(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/expr/src/ > window_state.rs:95) > 2025-06-06T13:57:54.1905310Z at > > datafusion_physical_expr::window::window_expr::AggregateWindowExpr::aggregate_evaluate_stateful(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/physical-expr/src/window/ > window_expr.rs:260) > 2025-06-06T13:57:54.1920612Z at > <datafusion_physical_expr::window::aggregate::PlainAggregateWindowExpr > as > datafusion_physical_expr::window::window_expr::WindowExpr>::evaluate_stateful(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/physical-expr/src/window/ > aggregate.rs:148) > 2025-06-06T13:57:54.1924024Z at > > datafusion_physical_plan::windows::bounded_window_agg_exec::BoundedWindowAggStream::compute_aggregates(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/physical-plan/src/windows/ > bounded_window_agg_exec.rs:983) > 2025-06-06T13:57:54.1927398Z at > > datafusion_physical_plan::windows::bounded_window_agg_exec::BoundedWindowAggStream::poll_next_inner(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/physical-plan/src/windows/ > bounded_window_agg_exec.rs:1033) > 2025-06-06T13:57:54.1930653Z at > > <datafusion_physical_plan::windows::bounded_window_agg_exec::BoundedWindowAggStream > as > futures_core::stream::Stream>::poll_next(/usr/local/cargo/git/checkouts/datafusion-11a8b534adb6bd68/85f6621/datafusion/physical-plan/src/windows/ > bounded_window_agg_exec.rs:949) > > There was one PR between rc1 and rc2 specifically related to > evaluating window expressions, so I wonder if that is the issue. I > will try and confirm. > > https://github.com/apache/datafusion/pull/16234 > > > I am -1 on the release for now. > > On Fri, Jun 6, 2025 at 3:34 AM Wang Xudong <xudong...@apache.org> wrote: > > > Hi, > > > > I would like to propose a release of Apache DataFusion version 48.0.0. > > > > This release candidate is based on commit: > > 85f6621a6b1680b40d483a56b10ff3495861ece3 [1] > > The proposed release tarball and signatures are hosted at [2]. > > The changelog is located at [3]. > > > > Please download, verify checksums and signatures, run the unit tests, and > > vote > > on the release. The vote will be open for at least 72 hours. > > > > Only votes from PMC members are binding, but all members of the community > > are > > encouraged to test the release and vote with "(non-binding)". > > > > The standard verification procedure is documented at > > > > > https://github.com/apache/datafusion/blob/main/dev/release/README.md#verifying-release-candidates > > . > > > > [ ] +1 Release this as Apache DataFusion 48.0.0 > > [ ] +0 > > [ ] -1 Do not release this as Apache DataFusion 48.0.0 because... > > > > Here is my vote: > > > > +1 > > > > [1]: > > > > > https://github.com/apache/datafusion/tree/85f6621a6b1680b40d483a56b10ff3495861ece3 > > [2]: > > > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-48.0.0-rc2 > > [3]: > > > > > https://github.com/apache/datafusion/blob/85f6621a6b1680b40d483a56b10ff3495861ece3/CHANGELOG.md > > >
