With 3 +1 votes the release is approved (we just barely got by) Thank you Andy and L.C. for voting and helping to make it happen
Success! The release is available here: https://dist.apache.org/repos/dist/release/datafusion/datafusion-sqlparser-rs-0.53.0 I have also uploaded it to crates.io: https://crates.io/crates/sqlparser/0.53.0 Thanks again, Andrew On Wed, Dec 18, 2024 at 12:37 PM Andy Grove <andygrov...@gmail.com> wrote: > +1 (binding) > > I ran into the same issue with cargo publish but commented that out. > > Thanks, Andrew. > > On Thu, Dec 12, 2024 at 1:58 PM Andrew Lamb <andrewlam...@gmail.com> > wrote: > > > Thank you for sticking with it :pray: > > > > On Thu, Dec 12, 2024 at 2:17 PM L. C. Hsieh <vii...@gmail.com> wrote: > > > > > Okay. Once commented out the `cargo publish` step, it is okay. > > > > > > +1 (binding) > > > > > > Verified on M3 Mac. > > > > > > Thanks Andrew. > > > > > > On Thu, Dec 12, 2024 at 11:00 AM Andrew Lamb <al...@influxdata.com> > > wrote: > > > > > > > > Yes, unfortunately that happens due to [1] > > > > > > > > I think we just need to adjust the verification script to not run > > `cargo > > > > publish` > > > > > > > > [1]: https://github.com/apache/datafusion-sqlparser-rs/issues/1596 > > > > > > > > On Thu, Dec 12, 2024 at 1:10 PM L. C. Hsieh <vii...@gmail.com> > wrote: > > > > > > > > > Ah, I didn't notice that this is RC2. > > > > > > > > > > But I got another issue when running `verify-release-candidate.sh` > > with > > > > > RC2: > > > > > > > > > > > > > > > ``` > > > > > error: failed to prepare local package for uploading > > > > > > > > > > > > > > > Caused by: > > > > > > > > > > failed to select a version for the requirement `sqlparser_derive > = > > > > > "^0.3.0"` > > > > > > > > > > candidate versions found which didn't match: 0.2.2, 0.2.1, 0.2.0, > > ... > > > > > > > > > > location searched: crates.io index > > > > > > > > > > required by package `sqlparser v0.53.0 > > > > > > > > > > > > > > > > (/private/var/folders/26/jr5lms716817rm8_wsr3w7n80000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.fAm3tRoszd/apache-datafusion-sqlparser-rs-0.53.0)` > > > > > ``` > > > > > > > > > > On Thu, Dec 12, 2024 at 9:56 AM Andrew Lamb < > andrewlam...@gmail.com> > > > > > wrote: > > > > > > > > > > > > Thanks L.C. I also saw that problem with RC1 but thought I fixed > it > > > in > > > > > RC2 > > > > > > (the PR[1] is here) > > > > > > > > > > > > Can you confirm you are seeing this with RC2 as well? > > > > > > > > > > > > Andrew > > > > > > > > > > > > [1]: https://github.com/apache/datafusion-sqlparser-rs/pull/1595 > > > > > > > > > > > > On Thu, Dec 12, 2024 at 10:08 AM L. C. Hsieh <vii...@gmail.com> > > > wrote: > > > > > > > > > > > > > There are a few format issues while running > > > > > `verify-release-candidate.sh`: > > > > > > > > > > > > > > > > > > > > > ``` > > > > > > > > > > > > > > + cargo fmt --all -- --check > > > > > > > > > > > > > > Diff in > > > > > > > > > > > > > > > > > > /private/var/folders/26/jr5lms716817rm8_wsr3w7n80000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.JaesmyIQIo/apache-datafusion-sqlparser-rs-0.53.0/derive/src/ > > > > > > > lib.rs:18: > > > > > > > > > > > > > > use proc_macro2::TokenStream; > > > > > > > > > > > > > > use quote::{format_ident, quote, quote_spanned, ToTokens}; > > > > > > > > > > > > > > use syn::spanned::Spanned; > > > > > > > > > > > > > > -use syn::{parse::{Parse, ParseStream}, parse_macro_input, > > > > > > > parse_quote, Attribute, Data, DeriveInput, Fields, > GenericParam, > > > > > > > Generics, Ident, Index, LitStr, Meta, Token, Type, TypePath}; > > > > > > > > > > > > > > +use syn::{ > > > > > > > > > > > > > > + parse::{Parse, ParseStream}, > > > > > > > > > > > > > > + parse_macro_input, parse_quote, Attribute, Data, > > DeriveInput, > > > > > > > Fields, GenericParam, Generics, > > > > > > > > > > > > > > + Ident, Index, LitStr, Meta, Token, Type, TypePath, > > > > > > > > > > > > > > +}; > > > > > > > > > > > > > > use syn::{Path, PathArguments}; > > > > > > > > > > > > > > > > > > > > > > > > > > > > /// Implementation of `[#derive(Visit)]` > > > > > > > > > > > > > > Diff in > > > > > > > > > > > > > > > > > > /private/var/folders/26/jr5lms716817rm8_wsr3w7n80000gn/T/datafusion-sqlparser-rs-0.53.0.XXXXX.JaesmyIQIo/apache-datafusion-sqlparser-rs-0.53.0/derive/src/ > > > > > > > lib.rs:267: > > > > > > > > > > > > > > } > > > > > > > > > > > > > > > > > > > > > > > > > > > > fn is_option(ty: &Type) -> bool { > > > > > > > > > > > > > > - if let Type::Path(TypePath { path: Path { segments, .. }, > .. > > > }) = > > > > > ty { > > > > > > > > > > > > > > + if let Type::Path(TypePath { > > > > > > > > > > > > > > + path: Path { segments, .. }, > > > > > > > > > > > > > > + .. > > > > > > > > > > > > > > + }) = ty > > > > > > > > > > > > > > + { > > > > > > > > > > > > > > if let Some(segment) = segments.last() { > > > > > > > > > > > > > > if segment.ident == "Option" { > > > > > > > > > > > > > > if let PathArguments::AngleBracketed(args) = > > > > > > > &segment.arguments { > > > > > > > > > > > > > > ``` > > > > > > > > > > > > > > On Thu, Dec 12, 2024 at 6:52 AM Andrew Lamb < > > al...@influxdata.com> > > > > > wrote: > > > > > > > > > > > > > > > > Hi, > > > > > > > > > > > > > > > > I would like to propose a release of Apache DataFusion > > > sqlparser-rs > > > > > > > version > > > > > > > > 0.53.0. > > > > > > > > > > > > > > > > Notes: > > > > > > > > 1. This is RC2 (RC1 hit [6]) > > > > > > > > 2. there is a known, but I don't think blocking, issue with > the > > > > > > > > verification script[7] > > > > > > > > > > > > > > > > This release candidate is based on commit: > > > > > > > > e7d2c852918fe273a4f13288eae3c95cc99dff30 [1] > > > > > > > > The proposed release tarball and signatures are hosted at > [2]. > > > > > > > > The changelog is located at [3]. > > > > > > > > > > > > > > > > Note this release was built from branch-0.53[4], not main, > > which > > > adds > > > > > > > > 1. the ASF license header to a newly added file (spans.rs > )[5] > > > > > > > > 2. runs cargo fmt on derive [6] > > > > > > > > > > > > > > > > Please download, verify checksums and signatures, run the > unit > > > > > tests, and > > > > > > > > vote > > > > > > > > on the release. The vote will be open for at least 72 hours. > > > > > > > > > > > > > > > > Only votes from PMC members are binding, but all members of > the > > > > > community > > > > > > > > are > > > > > > > > encouraged to test the release and vote with "(non-binding)". > > > > > > > > > > > > > > > > The standard verification procedure is documented at > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion-sqlparser-rs/blob/main/dev/release/README.md#verifying-release-candidates > > > > > > > > . > > > > > > > > > > > > > > > > [ ] +1 Release this as Apache DataFusion sqlparser-rs 0.53.0 > > > > > > > > [ ] +0 > > > > > > > > [ ] -1 Do not release this as Apache DataFusion sqlparser-rs > > > 0.53.0 > > > > > > > > because... > > > > > > > > > > > > > > > > Here is my vote: > > > > > > > > > > > > > > > > +1 > > > > > > > > > > > > > > > > [1]: > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion-sqlparser-rs/tree/e7d2c852918fe273a4f13288eae3c95cc99dff30 > > > > > > > > [2]: > > > > > > > > > > > > > > > > > > > > > > > > > > https://dist.apache.org/repos/dist/dev/datafusion/apache-datafusion-sqlparser-rs-0.53.0-rc2 > > > > > > > > [3]: > > > > > > > > > > > > > > > > > > > > > > > > > > https://github.com/apache/datafusion-sqlparser-rs/blob/e7d2c852918fe273a4f13288eae3c95cc99dff30/CHANGELOG.md > > > > > > > > > > > > > > > > [4]: > > > > > https://github.com/apache/datafusion-sqlparser-rs/tree/branch-0.53 > > > > > > > > [5]: > > https://github.com/apache/datafusion-sqlparser-rs/pull/1594 > > > > > > > > [6]: > > https://github.com/apache/datafusion-sqlparser-rs/pull/1595 > > > > > > > > [7]: > > > https://github.com/apache/datafusion-sqlparser-rs/issues/1596 > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > > > > > > For additional commands, e-mail: > dev-h...@datafusion.apache.org > > > > > > > > > > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > > > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > > > > > > > > > > > > > --------------------------------------------------------------------- > > > To unsubscribe, e-mail: dev-unsubscr...@datafusion.apache.org > > > For additional commands, e-mail: dev-h...@datafusion.apache.org > > > > > > > > >
