rootvector2 commented on PR #3680: URL: https://github.com/apache/cxf/pull/3680#issuecomment-6847178092
Pushed 35717c41. 1. `setTimeToLive` / `setFutureTimeToLive` now take `Integer` to match the getters, so `Introspector` finds a write method again (`null` falls back to the contextual property). `timeToLiveCanBeSetAsBeanProperties` sets both through the introspected `PropertyDescriptor` write methods, the way Spring/Blueprint does, and fails with the old `int` setters. 2. Went with your suggestion: for the future check `0` now means no skew allowed and only a negative value disables it, with a test for each. `timeToLive` still treats `<= 0` as disabled since `0` there would reject every message, and there's a comment on that in `verifyDateHeader`. The javadoc and release note spell out both rules and that disabling the future check keeps a future-dated `Date` valid until that date. `createSpecExampleVerifier` now passes `-1`. Module tests and `JAXRSHTTPSignatureTest` pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
