rootvector2 commented on PR #3670: URL: https://github.com/apache/cxf/pull/3670#issuecomment-6672167579
Pushed 1522d5f2. 1, 2. `IOUtils.readStringFromStream` and `readBytesFromStream` close the stream, so all eight filters now set `new ByteArrayInputStream(new byte[0])` before the empty-content return, on the request context for the server filters and on the response context for the client ones. 3. `isCheckEmptyStream` and `setCheckEmptyStream` are `@Deprecated` in the four base classes, with a `@deprecated` Javadoc tag. 4. The test helpers used `ByteArrayInputStream`, whose `close()` is a no-op, so they couldn't catch this. They now wrap the body in a stream that throws once closed, like a servlet stream, and each filter has a test that reads the entity after an empty GET request or DELETE response. All eight fail on 8b5911bf. The module's 40 tests pass with checkstyle and PMD, and the 118 JOSE systests in `systests/rs-security` still pass. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
