ffang commented on PR #3676: URL: https://github.com/apache/cxf/pull/3676#issuecomment-6621179093
Thanks @reta, LGTM. Going back to the httpcore5 default (`Http1Config.INIT_BUF_SIZE` is 32768 in 5.4.4) makes sense now that the `SharedInputBuffer` deadlock is fixed (CXF-9268), and using 32 KiB for the conduit buffers when `chunkLength` isn't set matches the size already used when the request is re-sent. The hc5 tests and the async transport systests pass, and so does the reporter's test from CXF-9268 with the new defaults. One small thing: - `URLConnectionAsyncHTTPConduit` still uses `16320` in both places (lines 313 and 888), while it gets the same 32 KiB HTTP/1.1 blocks from the factory. Could it be changed the same way, for consistency? Thanks! Freeman -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
