ffang commented on PR #3688: URL: https://github.com/apache/cxf/pull/3688#issuecomment-6690779737
> LGTM, two nits: > > * getPinnedAlias(...) is computed twice. Compute it once before the if chain. > * There’s no blank line between the old validateCertificateChain overload and the javadoc of the new one. Thanks @coheigea ! Revised accordingly here https://github.com/apache/cxf/pull/3688/changes/51636711dd02ad473e12817578130463dd76fea1 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
