RusJaI commented on code in PR #3597:
URL: https://github.com/apache/cxf/pull/3597#discussion_r4308671956
##########
core/src/main/java/org/apache/cxf/resource/URIResolver.java:
##########
@@ -65,6 +65,8 @@ public class URIResolver implements AutoCloseable {
private static final Logger LOG = LogUtils.getLogger(URIResolver.class);
private static final String ALLOWED_URL_SCHEMES_PROPERTY =
"org.apache.cxf.resource.uriresolver.allowedSchemes";
+ private static final String DENIED_URL_SCHEMES_PROPERTY =
Review Comment:
Thanks @reta , agreed on avoiding another property.
One clarification that affects the approach: in the released versions
(3.6.12, 4.1.6+, 4.2.1+), `allowedSchemes` is additive. `getAllowedSchemes()`
starts with `DEFAULT_ALLOWED_URL_SCHEMES` and adds the configured schemes, so
it cannot currently exclude `http`, `https`, or `file`.
For now, I'll proceed as follows:
1. **Keep this PR limited to the `EndpointReferenceUtils` change**,
preventing remote schema fetching in `SchemaLSResourceResolver` without
introducing configuration changes. I'll remove `deniedSchemes` and the
`URIResolver` changes.
2. **Address restrictive `allowedSchemes` semantics separately**,
incorporating your feedback on the approach.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
