reta commented on code in PR #3443:
URL: https://github.com/apache/cxf/pull/3443#discussion_r3936460641
##########
rt/rs/extensions/search/src/main/java/org/apache/cxf/jaxrs/ext/search/fiql/FiqlParser.java:
##########
@@ -305,6 +338,40 @@ protected ASTNode<T> parseComparison(String expr) throws
SearchParseException {
throw new SearchParseException("Not a comparison expression: " + expr);
}
+ private int[] findComparator(String expr) {
Review Comment:
@coheigea I do understand the intent here, but does it actually make sense
to go such far (basically rewriting what regex is doing)? We've limited the
expression length, I think the issue should be largely mitigated, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
