reta commented on code in PR #3370:
URL: https://github.com/apache/cxf/pull/3370#discussion_r3776093417
##########
rt/rs/security/oauth-parent/oauth2/src/main/java/org/apache/cxf/rs/security/oauth2/provider/JCacheOAuthDataProvider.java:
##########
@@ -86,18 +96,65 @@ public JCacheOAuthDataProvider(String configFileURL,
String accessTokenCacheKey,
String refreshTokenCacheKey,
boolean storeJwtTokenKeyOnly) {
+ this(configFileURL, bus, clientCacheKey, accessTokenCacheKey,
refreshTokenCacheKey,
+ storeJwtTokenKeyOnly, CacheTTLs.ETERNAL);
+ }
+
+ // cacheTTLs lets the access/refresh token caches be evicted by the JCache
infrastructure
+ // itself once entries age out, independently of any application-level
expiry check;
+ // a TTL <= 0 (CacheTTLs.ETERNAL by default) leaves the corresponding
cache eternal
+ public JCacheOAuthDataProvider(String configFileURL,
Review Comment:
Thanks @coheigea , that is also a valid point, we may not even need it
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
