reta commented on code in PR #2960:
URL: https://github.com/apache/cxf/pull/2960#discussion_r2943828795
##########
rt/bindings/soap/src/main/java/org/apache/cxf/binding/soap/interceptor/ReadHeadersInterceptor.java:
##########
@@ -234,24 +232,6 @@ public void handleMessage(SoapMessage message) {
for (Element elem : elemList) {
Element hel = DOMUtils.getFirstElement(elem);
while (hel != null) {
- // Need to add any attributes that are present on
the parent element
Review Comment:
Thanks for the fix @jrihtarsic, it seems like the this functionality has
been active since the day one and could affect existing applications. I would
suggest to add contextual property
`org.apache.cxf.binding.soap.addParentAttributes` or similar:
```
final boolean addParentAttributes = MessageUtils.getContextualBoolean(
message,
"org.apache.cxf.binding.soap.addParentAttributes", false);
if (elem.hasAttributes() && addParentAttributes)
}
```
So you would be able to set this property whereas the risk to break existing
flows is minimal, thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
