reta commented on code in PR #2571:
URL: https://github.com/apache/cxf/pull/2571#discussion_r2300711115
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -195,23 +207,29 @@ RefCount<HttpClient> computeIfAbsent(final boolean
shareHttpClient, final HTTPCl
// Do not share if it is not allowed for the conduit or cache
capacity is exceeded
if (!shareHttpClient || clients.size() >= MAX_SIZE) {
Review Comment:
I would argue the collection does not need to locked:
- there is no modifications happening
- we also are not particularly worried that `size()` has to be absolutely
accurate
(In other words, invoking `size()` is absolutely thread-safe, the value may
not reflect the true state of the structure accurately)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
