reta commented on code in PR #2467:
URL: https://github.com/apache/cxf/pull/2467#discussion_r2152038227
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -844,6 +844,9 @@ public void close() throws IOException {
} catch (IOException e) {
logStackTrace(e);
}
+ if (wrappedStream == pout){
Review Comment:
Thank you
> The only negative side effect these changes could have is that they trade
an IOException (closed stream) for a NullpointerException if any of these
streams is deferenced after they were closed.
It think this should be non-issue, usage of the closed stream should never
happen
##########
rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java:
##########
@@ -844,6 +844,9 @@ public void close() throws IOException {
} catch (IOException e) {
logStackTrace(e);
}
+ if (wrappedStream == pout){
Review Comment:
Thank you
> The only negative side effect these changes could have is that they trade
an IOException (closed stream) for a NullpointerException if any of these
streams is deferenced after they were closed.
I think this should be non-issue, usage of the closed stream should never
happen
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
