reta commented on code in PR #2386: URL: https://github.com/apache/cxf/pull/2386#discussion_r2072270735
########## rt/transports/http/src/main/java/org/apache/cxf/transport/http/HttpClientHTTPConduit.java: ########## @@ -349,13 +348,6 @@ protected void setupConnection(Message message, Address address, HTTPClientPolic return; } - if (sslURL != null && isSslTargetDifferent(sslURL, uri)) { Review Comment: @CantosSong thanks for the fix, but I lack some context here why this reset on HTTPS URL was even introduced. I would suggest we play safe here and introduce the contextual property that would do the reset if needed: ``` final boolean resetClientNeeded = MessageUtils.getContextualBoolean(message, RESET_CLIENT_ON_HTTPS_URL_CHANGE); .... if (clientRef != null && resetClientNeeded) { } ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org