reta commented on code in PR #2370:
URL: https://github.com/apache/cxf/pull/2370#discussion_r2047980588
##########
rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/attachment/JAXBAttachmentMarshaller.java:
##########
@@ -80,7 +80,7 @@ public String addSwaRefAttachment(DataHandler handler) {
AttachmentImpl att = new AttachmentImpl(id, handler);
att.setXOP(false);
atts.add(att);
- return id;
+ return "cid:" + id;
Review Comment:
It looks like it,
> 3. swaRef
[WS-I Attachment Profile
1.0](http://www.ws-i.org/Profiles/AttachmentsProfile-1.0-2004-08-24.html)
defines mechanism to reference MIME attachment parts using
[swaRef](http://www.ws-i.org/Profiles/AttachmentsProfile-1.0-2004-08-24.html#Referencing_Attachments_from_the_SOAP_Envelope).
In this mechanism the content of XML element of type
[wsi:swaRef](http://ws-i.org/profiles/basic/1.1/xsd/) is sent as MIME
attachment and the element inside SOAP Body holds the reference to this
attachment in the CID URI scheme as defined by [RFC
2111](http://www.faqs.org/rfcs/rfc2111.html).
##########
rt/databinding/jaxb/src/main/java/org/apache/cxf/jaxb/attachment/JAXBAttachmentMarshaller.java:
##########
@@ -80,7 +80,7 @@ public String addSwaRefAttachment(DataHandler handler) {
AttachmentImpl att = new AttachmentImpl(id, handler);
att.setXOP(false);
atts.add(att);
- return id;
+ return "cid:" + id;
Review Comment:
It looks like it, thank you @qq1038765585
> 3. swaRef
[WS-I Attachment Profile
1.0](http://www.ws-i.org/Profiles/AttachmentsProfile-1.0-2004-08-24.html)
defines mechanism to reference MIME attachment parts using
[swaRef](http://www.ws-i.org/Profiles/AttachmentsProfile-1.0-2004-08-24.html#Referencing_Attachments_from_the_SOAP_Envelope).
In this mechanism the content of XML element of type
[wsi:swaRef](http://ws-i.org/profiles/basic/1.1/xsd/) is sent as MIME
attachment and the element inside SOAP Body holds the reference to this
attachment in the CID URI scheme as defined by [RFC
2111](http://www.faqs.org/rfcs/rfc2111.html).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
