reta commented on code in PR #2275:
URL: https://github.com/apache/cxf/pull/2275#discussion_r1964032961
##########
core/src/main/java/org/apache/cxf/io/DelayedCachedOutputStreamCleaner.java:
##########
@@ -167,7 +167,8 @@ public boolean equals(Object obj) {
}
final DelayedCloseable other = (DelayedCloseable) obj;
- return Objects.equals(closeable, other.closeable);
+ // because of the broken Liskov Substitution Principle, check in
two ways to find equal streams
+ return Objects.equals(other.closeable, closeable) ||
Objects.equals(closeable, other.closeable);
Review Comment:
Sorry @yurkom , I cannot push to your branch (may be because you pushed into
`main`), but I've cherrypicked you changes over here
https://github.com/apache/cxf/pull/2278, thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
