paulbors commented on code in PR #1781:
URL: https://github.com/apache/cxf/pull/1781#discussion_r1954938484


##########
rt/rs/client/src/main/java/org/apache/cxf/jaxrs/client/spec/ClientImpl.java:
##########
@@ -470,7 +472,7 @@ public WebTarget resolveTemplatesFromEncoded(Map<String, 
Object> templatesMap) {
         private WebTarget newWebTarget(UriBuilder newBuilder) {
             WebClient newClient;
             if (targetClient != null) {
-                newClient = WebClient.fromClient(targetClient);
+                newClient = threadSafeTargetClient ? targetClient : 
WebClient.fromClient(targetClient);

Review Comment:
   Or..... you can make a deep copy of the WebClient inside of 
WebClient.fromClient() instead of a shallow copy and you never have to worry 
about any of this (since its an immutable copy of it)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to