Thanks a lot Peter, that's great news, looking forward towards the (possible) 
release!
 
Best Regards,
    Andriy Redko 

> Thanks for the prompt reply, Andriy.

> After having a closer look at the changes in opentelemetry-semconv post 
> 1.24.0-alpha, I found that the removed classes were introduced back in this 
> commit so it should actually be safe for Quarkus to upgrade to 
> opentelemetry-semconv 1.25.0-alpha or 1.26.0-alpha. I am waiting for their 
> answer. 

> -- Peter

> On 08/08/2024 21:29, Andriy Redko wrote:
>> Hi Peter,

>> That is unexpected, sorry about that. The minor updates are generally 
>> considered safe but dependency on *-alpha 
>> artifacts is definitely in conflict here (both for CXF or/and Quarkus). May 
>> be the best option for CXF and Quarkus
>> would be to wait for semconv to become stable and only than rely on such 
>> conventions. Thanks for bringing this up.

>> Best Regards,
>>     Andriy Redko 


>>> Hi,

>>> as you may know I am the maintainer of Quarkus CXF 
>>> <https://github.com/quarkiverse/quarkus-cxf>.

>>> When trying to upgrade CXF from 4.0.4 to 4.0.5 in our 3.8 LTS branch, I 
>>> found out that it won't work because of missing class 
>>> io.opentelemetry.semconv.HttpAttributes.

>>> It is caused by this upgrade of opentelemetry-semconv from 1.23.1-alpha to 
>>> 1.24.0-alpha <https://github.com/apache/cxf/pull/1774> between CXF 4.0.4 
>>> and 4.0.5, where opentelemetry-semconv 1.24.0-alpha renamed 
>>> SemanticAttributes to HttpAttributes.

>>> CXF was adapted to that change around here 
>>> <https://github.com/apache/cxf/pull/1774/files#diff-c7f236ca73be741018e92028d79517c03d1bbc27fe58a1b8dd4258bb4a80b38eL62-R65>
>>>  but Quarkus 3.8 was not and it keeps using opentelemetry-semconv 
>>> 1.21.0-alpha in their 3.8 LTS branch. I believe their approach is correct 
>>> for an LTS branch.

>>> At the same time, there is no point in overriding any opentelemetry 
>>> dependency in favor of CXF on Quarkus CXF side, because (1) it could break 
>>> user applications and (2) Quarkus CXF relies on Quarkus Opentelemetry 
>>> configuration for GraalVM native image which tends to be quite sensitive to 
>>> changes of class names.

>>> It is perhaps not realistic to revert the opentelemetry-semconv upgrades 
>>> for CXF 4.0.6, but could we please be more careful about such breaking 
>>> changes in maintenance branches in the future?

>>> Thanks,

>>> -- Peter

Reply via email to