reta commented on code in PR #1819:
URL: https://github.com/apache/cxf/pull/1819#discussion_r1573288108
##########
core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java:
##########
@@ -323,21 +323,14 @@ public void thresholdReached() throws IOException {
* @param value the value to add
*/
private static void addHeader(Message message, String name, String value) {
- Map<String, List<String>> protocolHeaders = CastUtils.cast((Map<?,
?>)message
- .get(Message.PROTOCOL_HEADERS));
- if (protocolHeaders == null) {
- protocolHeaders = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
- message.put(Message.PROTOCOL_HEADERS, protocolHeaders);
+ Map<String, List<String>> headers = CastUtils.cast((Map<?,
?>)message.get(Message.PROTOCOL_HEADERS));
+ if (headers == null) {
+ headers = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
+ message.put(Message.PROTOCOL_HEADERS, headers);
}
- List<String> header =
CastUtils.cast((List<?>)protocolHeaders.get(name));
- if (header == null) {
- header = new ArrayList<>();
- protocolHeaders.put(name, header);
- }
- if (header.isEmpty()) {
+ List<String> header = headers.computeIfAbsent(name, k -> new
ArrayList<>());
+ if (header.isEmpty() || !header.contains(value)) {
Review Comment:
~@yvrng I think we are missing protocol headers update here:~
```
protocolHeaders.put(name, header);
```
My bad, the `protocolHeaders` -> `headers`, missed that
##########
core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java:
##########
@@ -323,21 +323,14 @@ public void thresholdReached() throws IOException {
* @param value the value to add
*/
private static void addHeader(Message message, String name, String value) {
- Map<String, List<String>> protocolHeaders = CastUtils.cast((Map<?,
?>)message
- .get(Message.PROTOCOL_HEADERS));
- if (protocolHeaders == null) {
- protocolHeaders = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
- message.put(Message.PROTOCOL_HEADERS, protocolHeaders);
+ Map<String, List<String>> headers = CastUtils.cast((Map<?,
?>)message.get(Message.PROTOCOL_HEADERS));
+ if (headers == null) {
+ headers = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
+ message.put(Message.PROTOCOL_HEADERS, headers);
}
- List<String> header =
CastUtils.cast((List<?>)protocolHeaders.get(name));
- if (header == null) {
- header = new ArrayList<>();
- protocolHeaders.put(name, header);
- }
- if (header.isEmpty()) {
+ List<String> header = headers.computeIfAbsent(name, k -> new
ArrayList<>());
+ if (header.isEmpty() || !header.contains(value)) {
Review Comment:
~@yvrng I think we are missing protocol headers update here:~
```
protocolHeaders.put(name, header);
```
##########
core/src/main/java/org/apache/cxf/transport/common/gzip/GZIPOutInterceptor.java:
##########
@@ -323,21 +323,14 @@ public void thresholdReached() throws IOException {
* @param value the value to add
*/
private static void addHeader(Message message, String name, String value) {
- Map<String, List<String>> protocolHeaders = CastUtils.cast((Map<?,
?>)message
- .get(Message.PROTOCOL_HEADERS));
- if (protocolHeaders == null) {
- protocolHeaders = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
- message.put(Message.PROTOCOL_HEADERS, protocolHeaders);
+ Map<String, List<String>> headers = CastUtils.cast((Map<?,
?>)message.get(Message.PROTOCOL_HEADERS));
+ if (headers == null) {
+ headers = new TreeMap<>(String.CASE_INSENSITIVE_ORDER);
+ message.put(Message.PROTOCOL_HEADERS, headers);
}
- List<String> header =
CastUtils.cast((List<?>)protocolHeaders.get(name));
- if (header == null) {
- header = new ArrayList<>();
- protocolHeaders.put(name, header);
- }
- if (header.isEmpty()) {
+ List<String> header = headers.computeIfAbsent(name, k -> new
ArrayList<>());
+ if (header.isEmpty() || !header.contains(value)) {
Review Comment:
My bad, the `protocolHeaders` -> `headers`, missed that
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
