reta commented on code in PR #1670: URL: https://github.com/apache/cxf/pull/1670#discussion_r1477096242
########## rt/ws/rm/src/main/java/org/apache/cxf/ws/rm/ManagedRMEndpoint.java: ########## @@ -118,7 +119,7 @@ public class ManagedRMEndpoint implements ManagedComponent { } public ManagedRMEndpoint(RMEndpoint endpoint) { - this.endpoint = endpoint; + this.endpoint = Objects.requireNonNull(endpoint, "endpoint"); Review Comment: Thanks @pingpingy1 , I would prefer to be "sane" with `null` checks (we have thousands of places like that in the codebase), unless we have an issue with this code. The class is created and managed by CXF and it has not been susceptible to NPE here. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org