ffang commented on code in PR #1633:
URL: https://github.com/apache/cxf/pull/1633#discussion_r1449209095


##########
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/utils/HttpUtils.java:
##########
@@ -475,6 +475,9 @@ public static String getProtocolHeader(Message m, String 
name, String defaultVal
 
     public static String getBaseAddress(Message m) {
         String endpointAddress = getEndpointAddress(m);
+        if (endpointAddress.startsWith("ws")) {

Review Comment:
   This change is required to fix some websocket related tests failures with 
Jetty 12.
   
   We need this change because in Jetty 12 architect and API changes.
   For example, if the request url is "ws://localhost:31604/websocket" or 
"http://localhost:31604/websocket";, we want getBaseAddress() returns 
"/websocket".
   
   I pushed another commit here to honor "wss" protocol as well
   
https://github.com/apache/cxf/pull/1633/commits/20a0f1c5230c4907b2b03db1a7a12d7a0024baaf
   
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to