jgreffe commented on code in PR #945:
URL: https://github.com/apache/cxf/pull/945#discussion_r872143477
##########
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/osgi/Activator.java:
##########
@@ -91,6 +99,14 @@ public void updated(Dictionary config) throws
ConfigurationException {
if (logBinary != null) {
logging.setLogBinary(logBinary);
}
+
+ if (!sensitiveElementNames.isEmpty()) {
Review Comment:
@reta : wrong behaviour, condition should be removed to reflect if we
comment out the property key
##########
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/osgi/Activator.java:
##########
@@ -91,6 +99,14 @@ public void updated(Dictionary config) throws
ConfigurationException {
if (logBinary != null) {
logging.setLogBinary(logBinary);
}
+
+ if (!sensitiveElementNames.isEmpty()) {
+ logging.setSensitiveElementNames(sensitiveElementNames);
+ }
+
+ if (!sensitiveProtocolHeaderNames.isEmpty()) {
Review Comment:
Same here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
