reta commented on code in PR #940:
URL: https://github.com/apache/cxf/pull/940#discussion_r859871874
##########
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##########
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
connection, Queue dest) throw
}
private static Connection createConnection(String name) throws
JMSException {
- ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name
- +
"?broker.persistent=false");
- cf.setRedeliveryPolicy(redeliveryPolicy());
+ ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name);
Connection connection = cf.createConnection();
connection.start();
return connection;
}
private static Connection createXAConnection(String name,
TransactionManager tm) throws JMSException {
- ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name
- +
"?broker.persistent=false&jms.xaAckMode=1");
- cf.setRedeliveryPolicy(redeliveryPolicy());
- XaPooledConnectionFactory cfp = new XaPooledConnectionFactory(cf);
- cfp.setTransactionManager(tm);
- cfp.setConnectionFactory(cf);
- Connection connection = cfp.createConnection();
+ ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name);
+ ConnectionFactory cf1 = new ConnectionFactoryProxy(cf, new
TransactionHelperImpl(tm));
Review Comment:
@ehsavoie awesome! Could you submit a PR against [this
branch](https://github.com/reta/cxf/tree/artemis.attempt.2) (it it works for
you), thank you!
##########
rt/transports/jms/src/test/java/org/apache/cxf/transport/jms/util/MessageListenerTest.java:
##########
@@ -174,33 +183,21 @@ private void testTransactionalBehaviour(Connection
connection, Queue dest) throw
}
private static Connection createConnection(String name) throws
JMSException {
- ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name
- +
"?broker.persistent=false");
- cf.setRedeliveryPolicy(redeliveryPolicy());
+ ActiveMQConnectionFactory cf = new ActiveMQConnectionFactory("vm://" +
name);
Connection connection = cf.createConnection();
connection.start();
return connection;
}
private static Connection createXAConnection(String name,
TransactionManager tm) throws JMSException {
- ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name
- +
"?broker.persistent=false&jms.xaAckMode=1");
- cf.setRedeliveryPolicy(redeliveryPolicy());
- XaPooledConnectionFactory cfp = new XaPooledConnectionFactory(cf);
- cfp.setTransactionManager(tm);
- cfp.setConnectionFactory(cf);
- Connection connection = cfp.createConnection();
+ ActiveMQXAConnectionFactory cf = new
ActiveMQXAConnectionFactory("vm://" + name);
+ ConnectionFactory cf1 = new ConnectionFactoryProxy(cf, new
TransactionHelperImpl(tm));
Review Comment:
@ehsavoie awesome! Could you submit a PR against [this
branch](https://github.com/reta/cxf/tree/artemis.attempt.2) please (it it works
for you), thank you!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@cxf.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
