reta commented on a change in pull request #826:
URL: https://github.com/apache/cxf/pull/826#discussion_r700642575
##########
File path:
rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSConduit.java
##########
@@ -511,6 +511,7 @@ private synchronized void shutdownListeners() {
}
public synchronized void close() {
shutdownListeners();
+ jmsConfig.resetCachedReplyDestination();
Review comment:
One similar modification is need in `sendExchange` method, right now the
connection is closed before the `jmsConfig.resetCachedReplyDestination();`, so
there is no chance to delete temporary query. The correct sequence should be:
```
jmsConfig.resetCachedReplyDestination();
ResourceCloser.close(connection);
this.connection = null;
```
##########
File path:
rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSConduit.java
##########
@@ -511,6 +511,7 @@ private synchronized void shutdownListeners() {
}
public synchronized void close() {
shutdownListeners();
+ jmsConfig.resetCachedReplyDestination();
Review comment:
One similar modification is need in `sendExchange` method, right now the
connection is closed before the `jmsConfig.resetCachedReplyDestination();`, so
there is no chance to delete temporary query. The correct sequence should be:
```
jmsConfig.resetCachedReplyDestination();
ResourceCloser.close(connection);
this.connection = null;
```
Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
