reta commented on a change in pull request #826:
URL: https://github.com/apache/cxf/pull/826#discussion_r677899019
##########
File path:
rt/transports/jms/src/main/java/org/apache/cxf/transport/jms/JMSConduit.java
##########
@@ -282,6 +283,9 @@ private void sendAndReceiveMessage(final Exchange exchange,
final Object request
jmsConfig.getReceiveTimeout(),
jmsConfig.isPubSubNoLocal(),
exchange);
+ if (replyDestination instanceof TemporaryQueue) {
Review comment:
Thanks for the patch @valentin-matignon , I believe the this is not the
right place to delete the temporary queue.
- `JMSConfiguration` is the class that creates temporary queue (and caches
it)
- `JMSConfiguration` has the method `resetCachedReplyDestination` which
looks like the right place to delete the temporary queue (it caches the
destination in `replyToDestinationDest`)
- the `JMSConduit` should be likely calling
`JMSConfiguration::resetCachedReplyDestination()` on shutdown
- it would be great to have at least one test case for the issue
What do you think? Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
