brevilo commented on a change in pull request #806:
URL: https://github.com/apache/cxf/pull/806#discussion_r674276537
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
> I pulled your PR as-is, created a sample bundle to consume
`RestClientBuilderResolver` and played w/o `lazy` `cxf-rt-rs-mp-client` bundle
activation policy.
Sorry for being pedantic here but we need to be clear on this: did you pull
my PR and *then* tested the loader mechanism? In that order (it reads like
that)? It's of course expected to work that way. Instead of pulling the whole
PR you'd want to cherry-pick 2161767 only.
Please check your `cxf-rt-rs-mp-client` JAR's `MANIFEST.MF`. Does it contain
the `Bundle-ActivationPolicy` header? If so, which value? Only an existing
header with the value `lazy` will allow you to reproduce the issue.
> Just leave it empty, like `<cxf.bundle.activation.policy />`, it will be
equivalent to eager activation.
Ok, tested the new property and it works as expected (prevents the
activation policy header from being added in the first place). I'd now go ahead
and amend 3b1df04 accordingly. Ok?
> In general, yes, but it would be great to have reproducer for the problem,
to understand why it happens.
~~See above. `lazy` activation simply means that the bundle is never
STARTING or ACTIVE, so SPI Fly won't find it. As soon as you use `eager` (which
is the default anyway) the bundle is started and SPI Fly can do its job.~~
Hang on, I need to look into this some more...
> If it is easier for you, we could get capabilities merged (it is good
addition) and troubleshoot the bundle activation later on.
Doesn't really help since I need both 🤷♂️
Cheers
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
