reta commented on a change in pull request #806:
URL: https://github.com/apache/cxf/pull/806#discussion_r664161521
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
My bad @brevilo , apologies, should explain it in more details. Apache
CXF uses `cxf.bundle.activator` property (which is declared in `parent/pom.xml`
and (re)defined in `microprofile-client/pom.xml`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L44).
If you change it to empty value (or just remove it from `pom.xml` altogether),
the `Bundle-ActivationPolicy` manifest entry won't be included and you don't
need to do that:
```
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
```
Since the activator would be gone, it is very likely the exported services
should need to be changed as well (may be not, unsure about it but I could
look), so this where the second property, `cxf.export.service`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L41)
comes handy.
Hope it helps, please let me know if you still have questions, thanks.
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
My bad @brevilo , apologies, should have explained it in more details.
Apache CXF uses `cxf.bundle.activator` property (which is declared in
`parent/pom.xml` and (re)defined in `microprofile-client/pom.xml`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L44).
If you change it to empty value (or just remove it from `pom.xml` altogether),
the `Bundle-ActivationPolicy` manifest entry won't be included and you don't
need to do that:
```
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
```
Since the activator would be gone, it is very likely the exported services
should need to be changed as well (may be not, unsure about it but I could
look), so this where the second property, `cxf.export.service`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L41)
comes handy.
Hope it helps, please let me know if you still have questions, thanks.
##########
File path: rt/rs/microprofile-client/pom.xml
##########
@@ -185,6 +185,26 @@
<scope>test</scope>
</dependency>
</dependencies>
+
+ <build>
+ <plugins>
+ <plugin>
+ <groupId>org.apache.felix</groupId>
+ <artifactId>maven-bundle-plugin</artifactId>
+ <configuration>
+ <instructions>
+
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
Review comment:
My bad @brevilo , apologies, should have explained it in more details.
Apache CXF uses `cxf.bundle.activator` property which is declared in
`parent/pom.xml` and (re)defined in `microprofile-client/pom.xml`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L44).
If you change it to empty value (or just remove it from `pom.xml` altogether),
the `Bundle-ActivationPolicy` manifest entry won't be included and you don't
need to do that:
```
<_removeheaders>Bundle-ActivationPolicy</_removeheaders>
```
Since the activator would be gone, it is very likely the exported services
should need to be changed as well (may be not, unsure about it but I could
look), so this where the second property, `cxf.export.service`
(https://github.com/apache/cxf/blob/master/rt/rs/microprofile-client/pom.xml#L41)
comes handy.
Hope it helps, please let me know if you still have questions, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
