reta commented on a change in pull request #713:
URL: https://github.com/apache/cxf/pull/713#discussion_r511619713
##########
File path:
rt/features/logging/src/main/java/org/apache/cxf/ext/logging/MaskSensitiveHelper.java
##########
@@ -70,15 +71,19 @@ public String maskSensitiveElements(
final Message message,
final String originalLogString) {
if (replacementsXML.isEmpty() && replacementsJSON.isEmpty()
- || message == null
Review comment:
Why this condition was removed? It is exactly what will be returned on
line
https://github.com/apache/cxf/pull/713/files#diff-042c9128e111e120c63cbb7404cdc5d2d2e3c4377b40e01c097d4b8e7315191dR80
but with unnecessary use of `Optional::ofNullable(message)`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
