andymc12 commented on pull request #703: URL: https://github.com/apache/cxf/pull/703#issuecomment-704629566
> LGTM but can you also check these tests that are also failing in systests/rs-security? > > OIDCNegativeTest.testImplicitFlowNoNonce > OIDCNegativeTest.testImplicitFlowPromptNone Yes, it looks like these tests were expecting the response to throw an exception rather than return null. The javadoc is not clear what to expect (null vs ProcessingException that wraps a NoContentException), but the TCK expects that if the passed-in type can be null (i.e. not a primitive), then the readEntity method must return null. I updated the test to assertNull, and it is passing locally for me. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected]
