reta commented on a change in pull request #630: CXF-8201 add additional check
for file scheme in setUriParts
URL: https://github.com/apache/cxf/pull/630#discussion_r371596198
##########
File path:
rt/frontend/jaxrs/src/main/java/org/apache/cxf/jaxrs/impl/UriBuilderImpl.java
##########
@@ -661,6 +662,14 @@ private void setUriParts(URI uri) {
}
}
+ private boolean queryIsEmpty() {
+ return query == null || query.isEmpty();
+ }
+
+ private boolean sspMatchessPath(final URI uri) {
+ return uri.getRawSchemeSpecificPart() != null &&
uri.getRawSchemeSpecificPart().equals("//" + uri.getPath());
Review comment:
It would be good to check if `uri.getPath()` is not null, otherwise `"//" +
uri.getPath()` becomes something like `//null`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
With regards,
Apache Git Services
